Avoid timeouts when DRT fails to find a file.

Avoid timeouts when DRT fails to find a file.

Committed: https://code.google.com/p/dart/source/detail?r=16177

[Siggi Cherem (dart-lang), 2012-12-13 19:39:08]

This basically adds to test_controller.js and test.dart the extra setup needed
to catch these errors.

Basically we were not detecting when DRT fails to load an imported .dart file.
The problem is that these errors are not propagated to the window.onerror or
window error event. Following Anton's suggestion, I'm adding the onerror handler
on the script tag to fix the issue.

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
File samples/tests/samples/samples.status (right):

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
samples/tests/samples/samples.status:34: markdown_test: Skip # markdown_test
uses dart:io, it should only run in the vm
note with the latest fix from Anton and the changes in this CL this no longer
times out, yay!, but I don't think we need to run this test in DRT, so I'm
keeping it as Skip.

[Siggi Cherem (dart-lang), 2012-12-13 20:58:10]

https://codereview.chromium.org/11565018/diff/2001/tools/testing/dart/browser...
File tools/testing/dart/browser_test.dart (right):

https://codereview.chromium.org/11565018/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_test.dart:26: <script type="$scriptType"
src="$sourceScript" onerror="externalError(null)">
I could also just call directly showErrorAndExit, I'm not sure what is the post
message of the external error used for.

[Anton Muhin, 2012-12-14 01:50:06]

lgtm and thanks, Siggi

[ahe, 2012-12-14 07:55:46]

LGTM

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
File samples/tests/samples/samples.status (right):

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
samples/tests/samples/samples.status:34: markdown_test: Skip # markdown_test
uses dart:io, it should only run in the vm
On 2012/12/13 19:39:08, Siggi Cherem (dart-lang) wrote:
> note with the latest fix from Anton and the changes in this CL this no longer
> times out, yay!, but I don't think we need to run this test in DRT, so I'm
> keeping it as Skip.

I'd like to avoid skipping tests unless we absolutely have to.  Marking this
test as fail ensures that we don't regress on crashes and timeouts.

https://codereview.chromium.org/11565018/diff/2001/tools/testing/dart/browser...
File tools/testing/dart/browser_test.dart (right):

https://codereview.chromium.org/11565018/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_test.dart:26: <script type="$scriptType"
src="$sourceScript" onerror="externalError(null)">
On 2012/12/13 20:58:10, Siggi Cherem (dart-lang) wrote:
> I could also just call directly showErrorAndExit, I'm not sure what is the
post
> message of the external error used for.

showErrorAndExit doesn't actually exit because of the async nature of browser
tests.  It is important that the unittest framework is made aware of external
errors, otherwise it may cause the test to be recorded as passing.

[Siggi Cherem (dart-lang), 2012-12-14 19:13:01]

thanks guys!

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
File samples/tests/samples/samples.status (right):

https://codereview.chromium.org/11565018/diff/2001/samples/tests/samples/samp...
samples/tests/samples/samples.status:34: markdown_test: Skip # markdown_test
uses dart:io, it should only run in the vm
On 2012/12/14 07:55:46, ahe wrote:
> On 2012/12/13 19:39:08, Siggi Cherem (dart-lang) wrote:
> > note with the latest fix from Anton and the changes in this CL this no
longer
> > times out, yay!, but I don't think we need to run this test in DRT, so I'm
> > keeping it as Skip.
> 
> I'd like to avoid skipping tests unless we absolutely have to.  Marking this
> test as fail ensures that we don't regress on crashes and timeouts.

Thanks, done. I think I'd prefer having a dedicated test for the regression,
rather than using this random test, but we can do that as a follow up.