Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1156493010: Add a heartbeat for the test timeout. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/backend/invoker.dart View 6 chunks +29 lines, -13 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
nweiz
5 years, 6 months ago (2015-05-28 22:52:55 UTC) #2
kevmoo
LGTM w/ comment https://codereview.chromium.org/1156493010/diff/1/lib/src/backend/invoker.dart File lib/src/backend/invoker.dart (right): https://codereview.chromium.org/1156493010/diff/1/lib/src/backend/invoker.dart#newcode163 lib/src/backend/invoker.dart:163: var timeout = metadata.timeout.apply(new Duration(seconds: 30)); ...
5 years, 6 months ago (2015-05-29 01:26:46 UTC) #4
nweiz
https://codereview.chromium.org/1156493010/diff/1/lib/src/backend/invoker.dart File lib/src/backend/invoker.dart (right): https://codereview.chromium.org/1156493010/diff/1/lib/src/backend/invoker.dart#newcode163 lib/src/backend/invoker.dart:163: var timeout = metadata.timeout.apply(new Duration(seconds: 30)); On 2015/05/29 01:26:46, ...
5 years, 6 months ago (2015-05-29 20:25:39 UTC) #5
nweiz
5 years, 6 months ago (2015-05-29 20:25:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39b2a8c77fa36ae8fa2af77ff422f358fa9d848e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698