Move index closer to the plugin API

Move index closer to the plugin API

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/089038b085c38a0a134002dad6d01b3d6dd85642

[Brian Wilkerson, 2015-05-25 16:03:11]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-05-25 18:29:33]

LGTM

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/index_contributor.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:252:
_store.recordRelationship(new IndexableElement(element),
Could we use [this.]recordRelationship(element, kind, location) to avoid
repeating "new IndexableElement()" code?

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:780: static
LocationImpl createLocation(IndexableElement indexable) {
The same here - we need IndexableElement only for LocationImpl, so peekElement()
could continue returning just Element.

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/indexable_element.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/indexable_element.dart:78: final int
index;
Will this work?
So, we could avoid passing in through the constructor.
Not sure if it's a good design though.

final int index = IndexableObjectKind.nextIndex;

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/store/codec.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/codec.dart:70: class
ElementCodec {
It seems that this class needs more work.
We will need to rename it and update comments.
Please add TODO.

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/codec.dart:131: int
encodeHash(IndexableObject indexable) {
Could we move implementation into IndexableObjectKind?
So, we could avoid breaking encapsulation here.

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/index/dart_index_contributor_test.dart
(right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/index/dart_index_contributor_test.dart:142:
_assertNoRecordedRelation(new IndexableElement(variableElement),
Ouch...
Doing new IndexableElement(element) everywhere seems like a lot of RY.
Could we make it a task for _assert[No]RecordedRelation?

[Brian Wilkerson, 2015-06-01 13:20:08]

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/index_contributor.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:252:
_store.recordRelationship(new IndexableElement(element),
Done

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:780: static
LocationImpl createLocation(IndexableElement indexable) {
Given that this method is only invoked in one place, I inlined it.

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/indexable_element.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/indexable_element.dart:78: final int
index;
Done

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/store/codec.dart (right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/codec.dart:70: class
ElementCodec {
Done

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/codec.dart:131: int
encodeHash(IndexableObject indexable) {
TODO added so we don't forget in a future pass.

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/index/dart_index_contributor_test.dart
(right):

https://codereview.chromium.org/1156493004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/index/dart_index_contributor_test.dart:142:
_assertNoRecordedRelation(new IndexableElement(variableElement),
Done.

[Brian Wilkerson, 2015-06-01 15:25:47]

Committed patchset #1 (id:1) manually as
089038b085c38a0a134002dad6d01b3d6dd85642 (presubmit successful).