Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1156473004: update_homebrew: use async/await (Closed)

Created:
5 years, 6 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -102 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 4 chunks +115 lines, -99 lines 0 comments Download
M tools/apps/update_homebrew/pubspec.yaml View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 6 months ago (2015-05-29 20:47:52 UTC) #2
Bill Hesse
LGTM. Is this put through the formatter? https://codereview.chromium.org/1156473004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/1156473004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode20 tools/apps/update_homebrew/bin/update_homebrew.dart:20: const _githubRepo ...
5 years, 6 months ago (2015-06-01 07:38:48 UTC) #3
kevmoo
https://codereview.chromium.org/1156473004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/1156473004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode20 tools/apps/update_homebrew/bin/update_homebrew.dart:20: const _githubRepo = 'dart-lang/homebrew-dart'; On 2015/06/01 07:38:48, Bill Hesse ...
5 years, 6 months ago (2015-06-01 16:51:29 UTC) #4
kevmoo
5 years, 6 months ago (2015-06-01 16:51:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ebb0d0100dc3f942b4a6f76f1ded6cfa9d7015ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698