Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1156423002: VM: Fix two incorrect function fingerprints. (Closed)

Created:
5 years, 6 months ago by Florian Schneider
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix two incorrect function fingerprints. The checking code was broken for a while, so this mismatch was not noticed. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/88d316fbc0b25ecb467d3d0f882acd3b81b4b92a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 6 months ago (2015-05-28 13:49:19 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years, 6 months ago (2015-05-29 10:15:10 UTC) #3
Florian Schneider
5 years, 6 months ago (2015-05-29 10:20:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
88d316fbc0b25ecb467d3d0f882acd3b81b4b92a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698