Issue 11564015: Never try to add 0 bytes to free list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11564015: Never try to add 0 bytes to free list. (Closed)

Created:
8 years ago by Vyacheslav Egorov (Google)

Modified:
8 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Never try to add 0 bytes to free list. R=iposva@google.com BUG=dart:7288 Committed: https://code.google.com/p/dart/source/detail?r=16114

Patch Set 2 : add {} #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/pages.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan https://codereview.chromium.org/11564015/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/11564015/diff/1/runtime/vm/pages.cc#newcode224 runtime/vm/pages.cc:224: if (free_size > 0) freelist_[type].Free(free_start, ...

8 years ago (2012-12-13 14:45:17 UTC) #2

Thanks for the review. Landing.

Expand Messages | Collapse Messages

Issue 11564015: Never try to add 0 bytes to free list. (Closed)

Description

Patch Set 1 #

Patch Set 2 : add {} #

Messages