Issue 11564013: Wat if you closure identical?

Issue 11564013: Wat if you closure identical? (Closed)

Created:
8 years ago by ngeoffray

Modified:
8 years ago

Reviewers:
ahe, floitsch, srdjan, kasperl

CC:
reviews_dartlang.org, Max Heinritz (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Wat if you closure identical? Committed: https://code.google.com/p/dart/source/detail?r=16112

Patch Set 2 : #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
M	runtime/lib/identical_patch.dart	View		1 chunk	+1 line, -3 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	1	1 chunk	+3 lines, -3 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/identical_closure_test.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11564013/diff/1/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart File sdk/lib/_internal/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/11564013/diff/1/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart#newcode216 sdk/lib/_internal/compiler/implementation/lib/core_patch.dart:216: // This is very magic: the compiler knows ...

8 years ago (2012-12-13 14:23:22 UTC) #2

kasperl

https://codereview.chromium.org/11564013/diff/1/tests/language/identical_closure_test.dart File tests/language/identical_closure_test.dart (right): https://codereview.chromium.org/11564013/diff/1/tests/language/identical_closure_test.dart#newcode5 tests/language/identical_closure_test.dart:5: var myIdentical = identical; If you're keeping this as ...

8 years ago (2012-12-13 14:24:56 UTC) #3

ngeoffray

Thanks Kasper. https://codereview.chromium.org/11564013/diff/1/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart File sdk/lib/_internal/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/11564013/diff/1/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart#newcode216 sdk/lib/_internal/compiler/implementation/lib/core_patch.dart:216: // This is very magic: the compiler ...

8 years ago (2012-12-13 14:24:59 UTC) #4

srdjan

LGTM https://codereview.chromium.org/11564013/diff/3001/runtime/lib/identical_patch.dart File runtime/lib/identical_patch.dart (right): https://codereview.chromium.org/11564013/diff/3001/runtime/lib/identical_patch.dart#newcode5 runtime/lib/identical_patch.dart:5: patch bool identical(Object a, Object b) => a ...

8 years ago (2012-12-13 18:06:57 UTC) #5

ahe

8 years ago (2012-12-14 08:40:39 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/11564013/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/lib/core_patch.dart (right):

https://codereview.chromium.org/11564013/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/core_patch.dart:217: // identical,
so we can just express identical in terms of itself.
Really?

Expand Messages | Collapse Messages