Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1156373008: cps_ir: Handle malformed type arguments and type checks. (Closed)

Created:
5 years, 6 months ago by karlklose
Modified:
5 years, 6 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps_ir: Handle malformed type arguments and type checks. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/993338408e3a5540fe1075ae12e2eb9859f80537

Patch Set 1 : Rebase test expectations. #

Patch Set 2 : Actual change plus status updates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -131 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 chunks +13 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 10 chunks +12 lines, -33 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/corelib.status View 5 chunks +12 lines, -14 lines 0 comments Download
M tests/html/html.status View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 17 chunks +52 lines, -64 lines 0 comments Download
M tests/lib/lib.status View 5 chunks +9 lines, -10 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
karlklose
5 years, 6 months ago (2015-05-28 13:59:45 UTC) #3
asgerf
LGTM
5 years, 6 months ago (2015-05-28 14:23:02 UTC) #4
karlklose
5 years, 6 months ago (2015-05-29 07:54:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
993338408e3a5540fe1075ae12e2eb9859f80537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698