Issue 1156223005: Remove AnalysisContext.visibleLibraries getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156223005: Remove AnalysisContext.visibleLibraries getter. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove AnalysisContext.visibleLibraries getter. It is not used anymore. It's functionality is not clear. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9a70cb53332b6cf8010f4c7edc4ae0684af99cc2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	pkg/analyzer/test/src/context/context_test.dart	View	1	3 chunks	+16 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Brian Wilkerson

> Remove AnalysisContext.visibleLibraries getter. Actually, it's LibraryElement.visibleLibraries. > It is not used anymore. By us, ...

5 years, 6 months ago (2015-06-01 15:56:47 UTC) #2

scheglov

OK I will keep it for now. PTAL On 2015/06/01 15:56:47, Brian Wilkerson wrote: > ...

5 years, 6 months ago (2015-06-01 16:31:23 UTC) #3

Brian Wilkerson

LGTM, although I expected to see @deprecated annotations...

5 years, 6 months ago (2015-06-01 16:38:08 UTC) #4

scheglov

5 years, 6 months ago (2015-06-01 16:40:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9a70cb53332b6cf8010f4c7edc4ae0684af99cc2 (presubmit successful).