Issue 1156183002: privatize and remove some fields in Isolate response

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156183002: privatize and remove some fields in Isolate response (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

privatize and remove some fields in Isolate response - Remove features - Make heaps -> _heaps - Make tagCounters -> _tagCounters. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/f01b6dd5b294001cf4a96b4fbebc9a8753dcee81

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -34 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View		3 chunks	+2 lines, -16 lines	0 comments	Download
M	runtime/observatory/tests/service/get_isolate_rpc_test.dart	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	4 chunks	+2 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 7 months ago (2015-05-26 21:05:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f01b6dd5b294001cf4a96b4fbebc9a8753dcee81 (presubmit successful).