Don't try to put symlinked files in archive.

Don't try to put symlinked files in archive.

Committed: https://code.google.com/p/dart/source/detail?r=16079

[Bob Nystrom, 2012-12-12 23:47:05]

This was the least intrusive fix I could come up with. Added lots of reviewers
for extra sanity checking.

[nweiz, 2012-12-12 23:49:18]

LGTM

I'll work on making a cleaner version of this for use post-M2.

[Jennifer Messerly, 2012-12-12 23:49:25]

https://codereview.chromium.org/11558036/diff/1/utils/pub/command_lish.dart
File utils/pub/command_lish.dart (right):

https://codereview.chromium.org/11558036/diff/1/utils/pub/command_lish.dart#n...
utils/pub/command_lish.dart:169: // TODO(rnystrom): dir.list() will paths with
resolved symlinks.
"will include paths" ?

https://codereview.chromium.org/11558036/diff/1/utils/pub/command_lish.dart#n...
utils/pub/command_lish.dart:176: if (entry.length > 1 && entry.startsWith('..'))
return null;
entry.startsWith('..') implies entry.length > 1 right?

also might want to do "../"

[Siggi Cherem (dart-lang), 2012-12-12 23:53:56]

what John said

https://codereview.chromium.org/11558036/diff/1/utils/pub/command_lish.dart
File utils/pub/command_lish.dart (right):

https://codereview.chromium.org/11558036/diff/1/utils/pub/command_lish.dart#n...
utils/pub/command_lish.dart:169: // TODO(rnystrom): dir.list() will paths with
resolved symlinks.
On 2012/12/12 23:49:25, John Messerly wrote:
> "will include paths" ?

woah - I wrote something about this and when I hit save, John's comment showed
up. Magical :)

[Bob Nystrom, 2012-12-12 23:54:02]

PTAL!

[Siggi Cherem (dart-lang), 2012-12-12 23:54:49]

lgtm

[nweiz, 2012-12-12 23:55:40]

lgtm

[Jennifer Messerly, 2012-12-13 00:00:30]

lgtm #4!