Issue 11558022: Fix #7330.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11558022: Fix #7330. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, dgrove

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix #7330. Committed: https://code.google.com/p/dart/source/detail?r=16056

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	utils/pub/validator/lib.dart	View		2 chunks	+8 lines, -0 lines	2 comments	Download
	M	utils/tests/pub/pub.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11558022/diff/1/utils/pub/validator/lib.dart File utils/pub/validator/lib.dart (right): https://codereview.chromium.org/11558022/diff/1/utils/pub/validator/lib.dart#newcode38 utils/pub/validator/lib.dart:38: We should probably do this in LishCommand._filesToPublish as ...

8 years ago (2012-12-12 19:43:49 UTC) #4

Bob Nystrom

8 years ago (2012-12-12 19:49:14 UTC) #5

Thanks!

https://codereview.chromium.org/11558022/diff/1/utils/pub/validator/lib.dart
File utils/pub/validator/lib.dart (right):

https://codereview.chromium.org/11558022/diff/1/utils/pub/validator/lib.dart#...
utils/pub/validator/lib.dart:38: 
On 2012/12/12 19:43:49, nweiz wrote:
> We should probably do this in LishCommand._filesToPublish as well.

Done. I added it to the other patch since that patch moves that code around a
bunch:
https://codereview.chromium.org/11557008/diff2/3001:5001/utils/pub/command_li...

Expand Messages | Collapse Messages