Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1155693004: Fix NPE in building element model when part URI could not be resolved (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix NPE in building element model when part URI could not be resolved R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d614533a9e27d0b95cf84ef860ac195359b81d77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +32 lines, -30 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-02 17:31:35 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-02 17:32:54 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-02 17:40:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d614533a9e27d0b95cf84ef860ac195359b81d77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698