Issue 1155583007: Load SDK sources from compiler_unsupported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155583007: Load SDK sources from compiler_unsupported. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub_test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Load SDK sources from compiler_unsupported. When running from the pub repo, dart2js needs to see SDK sources that match up with its own version. compiler_unsupported contains its own copy of the SDK for exactly this purpose; this CL loads SDK sources from that copy when running tests from the pub repo. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/6f379bd44af7749a6664a86fcd9aff514b64a516

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -8 lines)			Patch
	M	lib/src/barback/pub_package_provider.dart	View		4 chunks	+53 lines, -8 lines	0 comments	Download
	M	lib/src/utils.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 7 months ago (2015-05-28 00:10:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f379bd44af7749a6664a86fcd9aff514b64a516 (presubmit successful).

Expand Messages | Collapse Messages