Prepare CompilationUnitElementDelta in IncrementalCompilationUnitElementBuilder.

Prepare CompilationUnitElementDelta in IncrementalCompilationUnitElementBuilder.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b9dbeedb5415273a90e6b2e7872ed24befee5148

[Brian Wilkerson, 2015-06-02 15:50:41]

https://codereview.chromium.org/1155543005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1155543005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:4781: void replaceWith(CompilationUnit
other) {
I really don't think we want to add this to the public API, and certainly not
with the current semantics that the parent of the child nodes doesn't change.

Is that an important semantic to preserve? If not, perhaps this could be moved
to Incremental...Builder and the setters invoked to preserve the parent/child
relationships.

[scheglov, 2015-06-02 17:13:11]

PTAL

https://codereview.chromium.org/1155543005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1155543005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:4781: void replaceWith(CompilationUnit
other) {
On 2015/06/02 15:50:41, Brian Wilkerson wrote:
> I really don't think we want to add this to the public API, and certainly not
> with the current semantics that the parent of the child nodes doesn't change.
> 
> Is that an important semantic to preserve? If not, perhaps this could be moved
> to Incremental...Builder and the setters invoked to preserve the parent/child
> relationships.

Oops... You're right.
Removing it.

[Brian Wilkerson, 2015-06-02 17:29:54]

LGTM

[scheglov, 2015-06-02 18:03:09]

Committed patchset #2 (id:20001) manually as
b9dbeedb5415273a90e6b2e7872ed24befee5148 (presubmit successful).