Issue 1155473003: Don't schedule LIBRARY_ERRORS_READY for libraries that should not be analyzed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155473003: Don't schedule LIBRARY_ERRORS_READY for libraries that should not be analyzed. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't schedule LIBRARY_ERRORS_READY for libraries that should not be analyzed. This helps to save about 1500 ms, or about 10% on the analyzer project. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dbd2463d6d00ae9e45739e7c3a4bc9ae583f7899

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -73 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	3 chunks	+13 lines, -15 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	7 chunks	+63 lines, -57 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 7 months ago (2015-05-24 17:00:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dbd2463d6d00ae9e45739e7c3a4bc9ae583f7899 (presubmit successful).