Issue 11554021: Update Windows file implementation to use the unicode APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11554021: Update Windows file implementation to use the unicode APIs. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update Windows file implementation to use the unicode APIs. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16045

Patch Set 2 : Address comments. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -72 lines)			Patch
	M	runtime/bin/file_win.cc	View	1	8 chunks	+43 lines, -39 lines	0 comments	Download
	M	tests/standalone/io/file_error_test.dart	View		4 chunks	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11554021/diff/1/runtime/bin/file_win.cc File runtime/bin/file_win.cc (left): https://codereview.chromium.org/11554021/diff/1/runtime/bin/file_win.cc#oldcode250 runtime/bin/file_win.cc:250: const char* File::PathSeparator() { Maybe mention that this ...

8 years ago (2012-12-12 15:26:02 UTC) #2

Mads Ager (google)

8 years ago (2012-12-12 15:40:35 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11554021/diff/1/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (left):

https://codereview.chromium.org/11554021/diff/1/runtime/bin/file_win.cc#oldco...
runtime/bin/file_win.cc:250: const char* File::PathSeparator() {
On 2012/12/12 15:26:02, Søren Gjesse wrote:
> Maybe mention that this is already in UTF-8.

Done.

https://codereview.chromium.org/11554021/diff/1/runtime/bin/file_win.cc#oldco...
runtime/bin/file_win.cc:255: const char* File::StringEscapedPathSeparator() {
On 2012/12/12 15:26:02, Søren Gjesse wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages

Issue 11554021: Update Windows file implementation to use the unicode APIs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages