Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 11553027: Add client certificates to HttpsServer and HttpClient. (Closed)

Created:
8 years ago by Bill Hesse
Modified:
8 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add client certificates to HttpsServer and HttpClient. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16097

Patch Set 1 #

Patch Set 2 : Edit comments. #

Patch Set 3 : Remove stray changes from tests/standalone/io/https_server_test.dart #

Total comments: 3

Patch Set 4 : Minor change to test, fix type warning in http_impl.dart and in a test. #

Patch Set 5 : Remove two stray lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -17 lines) Patch
M runtime/bin/secure_socket.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket.cc View 3 chunks +6 lines, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 4 chunks +35 lines, -3 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 3 7 chunks +39 lines, -11 lines 0 comments Download
A tests/standalone/io/https_client_certificate_test.dart View 1 2 3 4 1 chunk +96 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
https://codereview.chromium.org/11553027/diff/3001/tests/standalone/io/https_client_certificate_test.dart File tests/standalone/io/https_client_certificate_test.dart (right): https://codereview.chromium.org/11553027/diff/3001/tests/standalone/io/https_client_certificate_test.dart#newcode90 tests/standalone/io/https_client_certificate_test.dart:90: test().chain(test).then((_) { Indentation is fixed.
8 years ago (2012-12-12 14:00:58 UTC) #1
Søren Gjesse
8 years ago (2012-12-12 15:27:07 UTC) #2
lgtm.

I think we should consider the callback solution, but for now this is OK.

https://codereview.chromium.org/11553027/diff/3001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/11553027/diff/3001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:832: /**
As discussed offline this makes the client certificate configuration global to
the HttpClient. This is probably OK, as adding optional certificate parameters
for all methods opening a connection would be a pain.

Another option would be to have a callback which is called when the server
requests a certificate. This callback would then be called the first time a
specific server requesting a certificate was contacted. After that this
certificate information would be cached.

https://codereview.chromium.org/11553027/diff/3001/tests/standalone/io/https_...
File tests/standalone/io/https_client_certificate_test.dart (right):

https://codereview.chromium.org/11553027/diff/3001/tests/standalone/io/https_...
tests/standalone/io/https_client_certificate_test.dart:72: // Run second test
with a certificate name.
How about moving this setting of the certificate name into the code in main? It
seems a bit subtle to have that here.

Powered by Google App Engine
This is Rietveld 408576698