Issue 11553023: Removed supression of a test failure on Safari

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11553023: Removed supression of a test failure on Safari (Closed)

Created:
8 years ago by kustermann

Modified:
8 years ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed supression of a test failure on Safari Committed: https://code.google.com/p/dart/source/detail?r=16031

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/11553023/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/11553023/diff/1/tests/html/html.status#newcode202 tests/html/html.status:202: # TODO: The following tests need to be ...

8 years ago (2012-12-12 11:41:50 UTC) #2

ahe

8 years ago (2012-12-14 08:45:34 UTC) #3

Message was sent while issue was closed.

Thank you. LGTM

https://codereview.chromium.org/11553023/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11553023/diff/1/tests/html/html.status#newcod...
tests/html/html.status:202: # TODO: The following tests need to be triaged to
understand why they are
On 2012/12/12 11:41:51, ricow1 wrote:
> could you file a bug for these, I don't think anybody will grep for this
> specific comment

Let's not file bugs for these things yet.  We have enough issues to deal with,
and we know that these files should be empty eventually.

Expand Messages | Collapse Messages