Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1155233002: cli_util DEPS (Closed)

Created:
5 years, 6 months ago by pquitslund
Modified:
5 years, 6 months ago
Reviewers:
ricow1, dgrove, sethladd
CC:
reviews_dartlang.org, keertip
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cli_util DEPS `cli_util` is consumed by *at least* dartanalyzer, the dev compiler and dartdoc. This change updates third_party to add `cli_util` and it's own deps (`when` and `which`). Note that `when` and `which` have both been transitioned to dartlang proper to ensure sanity moving forward. They're both independently useful. `which` especially for CLI tools. Committed: https://github.com/dart-lang/sdk/commit/7e5c54a5aafe4fc09877fb6cb08b76505427ac57

Patch Set 1 #

Total comments: 2

Patch Set 2 : unmirror #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M DEPS View 1 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
pquitslund
FWIW issues tracking reviews of `when` and `which`: https://github.com/dart-lang/when/issues/6 https://github.com/dart-lang/which/issues/9
5 years, 6 months ago (2015-05-26 20:27:22 UTC) #2
ricow1
https://codereview.chromium.org/1155233002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1155233002/diff/1/DEPS#newcode175 DEPS:175: (Var("dart_github") % "cli_util") + Var("cli_util_tag"), change this to "https://github.com/dart-lang/cli_util.git" ...
5 years, 6 months ago (2015-05-27 13:17:43 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1155233002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1155233002/diff/1/DEPS#newcode175 DEPS:175: (Var("dart_github") % "cli_util") + Var("cli_util_tag"), On 2015/05/27 13:17:42, ...
5 years, 6 months ago (2015-05-27 19:31:03 UTC) #4
pquitslund
Fixed. Issue tracking mirroring here: https://code.google.com/p/dart/issues/detail?id=23540
5 years, 6 months ago (2015-05-27 19:34:41 UTC) #5
pquitslund
5 years, 6 months ago (2015-05-27 19:37:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7e5c54a5aafe4fc09877fb6cb08b76505427ac57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698