Load deferred classes eagerly when generating script snapshots

Load deferred classes eagerly when generating script snapshots

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/fc3cd69c05a4e86c44be55abdd2f096bce4dc014

[srdjan, 2015-05-27 21:25:40]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-05-27 21:39:11]

LGTM.

Do we need a test that has some deferred libraries being loaded and we create a
script snapshot of the test and confirm that the libraries are loaded eagerly?

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:519: CommandLineOptions vm_options(argc);
Should be (argc + 1) to account for the extra argument being added, maybe we
should have a const defined above

const int EXTRA_VM_ARGUMENTS = 1;

and set this to

CommandLineOptions vm_options(argc + EXTRA_VM_ARGUMENTS);

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/main.cc#newcode875
runtime/bin/main.cc:875: CommandLineOptions vm_options(argc);
Ditto comment here about EXTAR_VM_OPTIONS.

In this file it needs to be 2 I think.

[srdjan, 2015-05-27 22:46:34]

I have verified that it works properly by running:
 dart--trace-loading  --snapshot= ...

A test is a little bit harder to make.

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:519: CommandLineOptions vm_options(argc);
On 2015/05/27 21:39:11, siva wrote:
> Should be (argc + 1) to account for the extra argument being added, maybe we
> should have a const defined above
> 
> const int EXTRA_VM_ARGUMENTS = 1;
> 
> and set this to
> 
> CommandLineOptions vm_options(argc + EXTRA_VM_ARGUMENTS);

Done.

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1155183003/diff/1/runtime/bin/main.cc#newcode875
runtime/bin/main.cc:875: CommandLineOptions vm_options(argc);
On 2015/05/27 21:39:11, siva wrote:
> Ditto comment here about EXTAR_VM_OPTIONS.
> 
> In this file it needs to be 2 I think.

Done.

[srdjan, 2015-05-28 00:12:14]

Committed patchset #3 (id:40001) manually as
fc3cd69c05a4e86c44be55abdd2f096bce4dc014 (presubmit successful).