Issue 11551002: Remove the windows constraint on the create_sdk ==> dart_analyzer dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11551002: Remove the windows constraint on the create_sdk ==> dart_analyzer dependency. (Closed)

Created:
8 years ago by devoncarew

Modified:
8 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove the windows constraint on the create_sdk ==> dart_analyzer dependency. So on all platforms now, the dart-sdk build depends on the compiler. Committed: https://code.google.com/p/dart/source/detail?r=16062

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -14 lines)			Patch
	M	dart.gyp	View		3 chunks	+2 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! How long have we been building the analyzer on windows? Cheers, Peter

8 years ago (2012-12-11 22:44:27 UTC) #2

devoncarew

8 years ago (2012-12-11 22:45:55 UTC) #3

On 2012/12/11 22:44:27, ahe wrote:
> LGTM!
> 
> How long have we been building the analyzer on windows?
> 
> Cheers,
> Peter

As part of the SDK? Since early this morning ;)

Expand Messages | Collapse Messages