Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 11549014: Issue 7278. Report static warnings for redirecting factory constructors (Closed)

Created:
8 years ago by scheglov
Modified:
8 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 7278. Report static warnings for redirecting factory constructors http://code.google.com/p/dart/issues/detail?id=7278 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -4 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 3 chunks +22 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +73 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years ago (2012-12-12 05:42:29 UTC) #1
Brian Wilkerson
8 years ago (2012-12-12 15:48:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698