Issue 1154853004: Fix invariant in ResolvedVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154853004: Fix invariant in ResolvedVisitor. (Closed)

Created:
5 years, 7 months ago by Johnni Winther

Modified:
5 years, 7 months ago

Reviewers:
karlklose, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix invariant in ResolvedVisitor. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/f14fa24a63b90d52582ed51641ab7d3bee47912b

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/resolved_visitor.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

Committed patchset #1 (id:1) manually as f14fa24a63b90d52582ed51641ab7d3bee47912b (presubmit successful).

5 years, 7 months ago (2015-05-26 13:51:41 UTC) #4

Siggi Cherem (dart-lang)

lgtm, thanks. Is this basically old code to validate that the new resolver is consistent ...

5 years, 7 months ago (2015-05-26 16:48:50 UTC) #6

Johnni Winther

5 years, 7 months ago (2015-05-27 07:12:54 UTC) #7

Message was sent while issue was closed.

On 2015/05/26 16:48:50, Siggi Cherem (dart-lang) wrote:
> lgtm, thanks. Is this basically old code to validate that the new resolver is
> consistent with the old one? (will this be deleted in the future?)

Yes, and it'll be removed soon (when SsaBuilder and SimpleTypeInferrer have been
rewritten to use the SemanticSendVisitor methods)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages