Issue 1154823003: Adjust context level when required before executing inlined finally clauses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154823003: Adjust context level when required before executing inlined finally clauses. (Closed)

Created:
5 years, 6 months ago by regis

Modified:
5 years, 6 months ago

Reviewers:
srdjan, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Adjust context level when required before executing inlined finally clauses. Add regression test. BUG=23537 R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/4bf6db0c2582423fff2d89709e566676bd945de3

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -27 lines)			Patch
M	runtime/vm/ast.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	9 chunks	+64 lines, -24 lines	0 comments	Download
A	tests/language/regress_23537_test.dart	View	1 chunk	+40 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

This is a fairly complex fix that we can discuss in person if you'd like. ...

5 years, 6 months ago (2015-06-03 03:23:02 UTC) #2

regis

5 years, 6 months ago (2015-06-03 17:31:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4bf6db0c2582423fff2d89709e566676bd945de3 (presubmit successful).