Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1154413004: Use github mirrors to pull dependencies (Closed)

Created:
5 years, 7 months ago by ricow1
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use github mirrors to pull dependencies There are several benefits of this: Devs and bots are pulling from the same location, so issues are easier to track down Devs can make sure the mirrors are working locally before rolling deps We pull from the same place for both dart-lang and community repos R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3e38d5abcdc9eb1a7bb35236b5a574a9e8e3a1fe

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -51 lines) Patch
M DEPS View 2 chunks +63 lines, -51 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
lgtm
5 years, 6 months ago (2015-05-28 12:15:55 UTC) #1
ricow1
5 years, 6 months ago (2015-05-28 12:24:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3e38d5abcdc9eb1a7bb35236b5a574a9e8e3a1fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698