Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154303005: Add lineLength parameter to edit.format request (issue 23519) (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add lineLength parameter to edit.format request (issue 23519) R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/07dd6b76492123caff2db811d844cd10e3655029

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -13 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 7 chunks +28 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 5 chunks +24 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-01 16:21:05 UTC) #2
jwren
LGTM. Increment version number of spec. The non-generated java code needs to be updated when ...
5 years, 6 months ago (2015-06-01 16:28:11 UTC) #3
jwren
https://codereview.chromium.org/1154303005/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (left): https://codereview.chromium.org/1154303005/diff/1/pkg/analysis_server/tool/spec/spec_input.html#oldcode8 pkg/analysis_server/tool/spec/spec_input.html:8: <h1 style="color:#999999">Version <version>1.6.2</version></h1> increment.
5 years, 6 months ago (2015-06-01 16:28:26 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 07dd6b76492123caff2db811d844cd10e3655029 (presubmit successful).
5 years, 6 months ago (2015-06-01 16:39:08 UTC) #5
Brian Wilkerson
5 years, 6 months ago (2015-06-01 16:40:20 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1154303005/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (left):

https://codereview.chromium.org/1154303005/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:8: <h1
style="color:#999999">Version <version>1.6.2</version></h1>
Updated to 1.7.0.

Powered by Google App Engine
This is Rietveld 408576698