Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1154263003: Revert "Make EfficientLength public, as EfficientLengthIterable." (Closed)

Created:
5 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make EfficientLength public, as EfficientLengthIterable." It's still not a good solution for detecting an Iterable with an efficient length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar generic Iterable transformers. Keep this as an internal optimization for quickly detecting the most common efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but don't make it public. A *real* solution would be adding a hasEfficientLength getter to Iterable, or adding an efficientLength getter that may return null if it's not efficient. This would something that a wrapper can attach to. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/babcd4e9c0af02c98ae95b974e79bc6f064f16c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -77 lines) Patch
M runtime/lib/array_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/collection_patch.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/collection_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 2 chunks +1 line, -32 lines 0 comments Download
M sdk/lib/collection/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/maps.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/iterable.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 9 chunks +24 lines, -10 lines 0 comments Download
M tests/corelib/growable_list_test.dart View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 6 months ago (2015-05-29 09:18:36 UTC) #2
Søren Gjesse
lgtm
5 years, 6 months ago (2015-05-29 09:34:17 UTC) #3
Lasse Reichstein Nielsen
5 years, 6 months ago (2015-05-29 10:52:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
babcd4e9c0af02c98ae95b974e79bc6f064f16c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698