|
Revert "Make EfficientLength public, as EfficientLengthIterable."
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.
Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.
A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.
R=sgjesse@google.com
Committed: https://github.com/dart-lang/sdk/commit/babcd4e9c0af02c98ae95b974e79bc6f064f16c8
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+62 lines, -77 lines) |
Patch |
|
M |
runtime/lib/array_patch.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/lib/collection_patch.dart
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
runtime/lib/growable_array.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/lib/immutable_map.dart
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
runtime/lib/string_patch.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/debugger_api_impl_test.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/collection_patch.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/js_array.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/js_helper.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/linked_hash_map.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/collection/iterable.dart
|
View
|
|
2 chunks |
+1 line, -32 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/list.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/maps.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/collection/queue.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/collection/splay_tree.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/core/iterable.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/core/list.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/core/set.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/internal/iterable.dart
|
View
|
|
9 chunks |
+24 lines, -10 lines |
0 comments
|
Download
|
|
M |
tests/corelib/growable_list_test.dart
|
View
|
|
4 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|