Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1153893005: Revert to use macro REG_MASK_BIT, now with parentheses. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert to use macro REG_MASK_BIT, now with parentheses. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/df2d1c426b1a3f939299ecf98188e1abd7799d0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 2 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 7 months ago (2015-05-27 16:13:10 UTC) #2
Bill Hesse
lgtm
5 years, 7 months ago (2015-05-27 17:18:18 UTC) #3
koda
5 years, 6 months ago (2015-05-28 20:03:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df2d1c426b1a3f939299ecf98188e1abd7799d0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698