Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1153733003: Make the tests work in the Dart repo. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the tests work in the Dart repo. I hadn't considered the case of running tests from within the Dart repo, but now the package-loading and SDK-detection logic works in that scenario as well. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/0bfb6e201d3fac6df51d4231c08dda4cad046a96

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M lib/src/io.dart View 1 2 chunks +11 lines, -4 lines 0 comments Download
M test/test_pub.dart View 5 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 6 months ago (2015-05-28 22:31:40 UTC) #1
Bob Nystrom
LGTM, though I feel the test code is getting increasingly hairy. :-/ https://codereview.chromium.org/1153733003/diff/1/lib/src/io.dart File lib/src/io.dart ...
5 years, 6 months ago (2015-05-29 20:15:55 UTC) #2
nweiz
Code review changes
5 years, 6 months ago (2015-05-29 20:33:28 UTC) #3
nweiz
> LGTM, though I feel the test code is getting increasingly hairy. :-/ While that's ...
5 years, 6 months ago (2015-05-29 20:33:32 UTC) #4
nweiz
5 years, 6 months ago (2015-05-29 20:33:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0bfb6e201d3fac6df51d4231c08dda4cad046a96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698