Use "package:" imports for pub.

Use "package:" imports for pub.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/a2373cc52677fb960781ed1c797fa5197db6cd8f

[Bob Nystrom, 2015-05-22 00:05:17]

Lots of nits then LGTM!

https://codereview.chromium.org/1153643002/diff/1/test/dependency_computer/ut...
File test/dependency_computer/utils.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/dependency_computer/ut...
test/dependency_computer/utils.dart:11: 
Alphabetize these with the above imports.

https://codereview.chromium.org/1153643002/diff/1/test/descriptor.dart
File test/descriptor.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/descriptor.dart#newcode12
test/descriptor.dart:12: 
Ditto.

https://codereview.chromium.org/1153643002/diff/1/test/descriptor/git.dart
File test/descriptor/git.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/descriptor/git.dart#ne...
test/descriptor/git.dart:9: import 'package:pub/src/git.dart' as git;
After path.

https://codereview.chromium.org/1153643002/diff/1/test/error_group_test.dart
File test/error_group_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/error_group_test.dart#...
test/error_group_test.dart:12: import 'package:pub/src/utils.dart';
Move up.

https://codereview.chromium.org/1153643002/diff/1/test/get/path/relative_path...
File test/get/path/relative_path_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/get/path/relative_path...
test/get/path/relative_path_test.dart:10: import
'package:pub/src/source_registry.dart';
With the above.

https://codereview.chromium.org/1153643002/diff/1/test/global/run/errors_if_o...
File test/global/run/errors_if_outside_bin_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/global/run/errors_if_o...
test/global/run/errors_if_outside_bin_test.dart:6: import
'package:path/path.dart' as p;
Swap.

https://codereview.chromium.org/1153643002/diff/1/test/implicit_dependency_te...
File test/implicit_dependency_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/implicit_dependency_te...
test/implicit_dependency_test.dart:9: import 'package:pub/src/barback.dart' as
barback;
Move these above the relative ones.

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/lock...
File test/list_package_dirs/lockfile_error_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/lock...
test/list_package_dirs/lockfile_error_test.dart:9: import
'package:pub/src/io.dart';
Move with above.

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/pubs...
File test/list_package_dirs/pubspec_error_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/pubs...
test/list_package_dirs/pubspec_error_test.dart:9: import
'package:pub/src/io.dart';
Merge with above.

https://codereview.chromium.org/1153643002/diff/1/test/package_list_files_tes...
File test/package_list_files_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/package_list_files_tes...
test/package_list_files_test.dart:12: import
'package:pub/src/system_cache.dart';
Move.

https://codereview.chromium.org/1153643002/diff/1/test/serve/utils.dart
File test/serve/utils.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/serve/utils.dart#newco...
test/serve/utils.dart:12: import 'package:http/http.dart' as http;
Swap.

https://codereview.chromium.org/1153643002/diff/1/test/serve/web_socket/path_...
File test/serve/web_socket/path_to_urls_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/serve/web_socket/path_...
test/serve/web_socket/path_to_urls_test.dart:8: import 'package:path/path.dart'
as p;
Swap.

https://codereview.chromium.org/1153643002/diff/1/test/validator/executable_t...
File test/validator/executable_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/validator/executable_t...
test/validator/executable_test.dart:9: import
'package:pub/src/validator/executable.dart';
Sort.

[nweiz, 2015-05-22 00:11:06]

Code review changes

[nweiz, 2015-05-22 00:11:45]

Committed patchset #2 (id:20001) manually as
a2373cc52677fb960781ed1c797fa5197db6cd8f (presubmit successful).

[nweiz, 2015-05-22 00:14:24]

https://codereview.chromium.org/1153643002/diff/1/test/dependency_computer/ut...
File test/dependency_computer/utils.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/dependency_computer/ut...
test/dependency_computer/utils.dart:11: 
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Alphabetize these with the above imports.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/descriptor.dart
File test/descriptor.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/descriptor.dart#newcode12
test/descriptor.dart:12: 
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/descriptor/git.dart
File test/descriptor/git.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/descriptor/git.dart#ne...
test/descriptor/git.dart:9: import 'package:pub/src/git.dart' as git;
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> After path.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/error_group_test.dart
File test/error_group_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/error_group_test.dart#...
test/error_group_test.dart:12: import 'package:pub/src/utils.dart';
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Move up.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/get/path/relative_path...
File test/get/path/relative_path_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/get/path/relative_path...
test/get/path/relative_path_test.dart:10: import
'package:pub/src/source_registry.dart';
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> With the above.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/global/run/errors_if_o...
File test/global/run/errors_if_outside_bin_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/global/run/errors_if_o...
test/global/run/errors_if_outside_bin_test.dart:6: import
'package:path/path.dart' as p;
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Swap.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/implicit_dependency_te...
File test/implicit_dependency_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/implicit_dependency_te...
test/implicit_dependency_test.dart:9: import 'package:pub/src/barback.dart' as
barback;
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Move these above the relative ones.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/pubs...
File test/list_package_dirs/pubspec_error_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/list_package_dirs/pubs...
test/list_package_dirs/pubspec_error_test.dart:9: import
'package:pub/src/io.dart';
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Merge with above.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/package_list_files_tes...
File test/package_list_files_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/package_list_files_tes...
test/package_list_files_test.dart:12: import
'package:pub/src/system_cache.dart';
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Move.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/serve/utils.dart
File test/serve/utils.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/serve/utils.dart#newco...
test/serve/utils.dart:12: import 'package:http/http.dart' as http;
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Swap.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/serve/web_socket/path_...
File test/serve/web_socket/path_to_urls_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/serve/web_socket/path_...
test/serve/web_socket/path_to_urls_test.dart:8: import 'package:path/path.dart'
as p;
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Swap.

Done.

https://codereview.chromium.org/1153643002/diff/1/test/validator/executable_t...
File test/validator/executable_test.dart (right):

https://codereview.chromium.org/1153643002/diff/1/test/validator/executable_t...
test/validator/executable_test.dart:9: import
'package:pub/src/validator/executable.dart';
On 2015/05/22 00:05:17, Bob Nystrom wrote:
> Sort.

Done.