Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11535003: Removed supressions of test failures on Safari (Closed)

Created:
8 years ago by kustermann
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed supressions of test failures on Safari Committed: https://code.google.com/p/dart/source/detail?r=15967

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -27 lines 4 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
8 years ago (2012-12-11 11:54:20 UTC) #1
ngeoffray
LGTM! Thanks Martin
8 years ago (2012-12-11 11:55:19 UTC) #2
ricow1
https://codereview.chromium.org/11535003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/11535003/diff/1/tests/html/html.status#newcode168 tests/html/html.status:168: # The following tests all fail in Safari 5.1. ...
8 years ago (2012-12-11 12:01:05 UTC) #3
Emily Fortuna
https://codereview.chromium.org/11535003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/11535003/diff/1/tests/html/html.status#newcode168 tests/html/html.status:168: # The following tests all fail in Safari 5.1. ...
8 years ago (2012-12-11 17:54:10 UTC) #4
ricow1
https://codereview.chromium.org/11535003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/11535003/diff/1/tests/html/html.status#newcode168 tests/html/html.status:168: # The following tests all fail in Safari 5.1. ...
8 years ago (2012-12-11 17:57:24 UTC) #5
Emily Fortuna
8 years ago (2012-12-11 18:00:09 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/11535003/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11535003/diff/1/tests/html/html.status#newcod...
tests/html/html.status:168: # The following tests all fail in Safari 5.1. (NOT
Mountain Lion). These will go
On 2012/12/11 17:57:24, ricow1 wrote:
> On 2012/12/11 17:54:10, Emily Fortuna wrote:
> > On 2012/12/11 12:01:05, ricow1 wrote:
> > > This comment is now outdated, the tests below do not have a valid reason
for
> > > failing
> > 
> > +1 Please remove this comment, Martin.
> 
> Well, we correctly need to triage these, so either put in a comment stating
that
> this needs to be triaged using the standard format or have one of the dart2js
> guys do it  while removing these

I agree; it's just the comment is not relevant now, so we should put a different
comment explaining what needs to be done.

Powered by Google App Engine
This is Rietveld 408576698