Issue 11534013: Issue 7282. Report error for deprecated === and !==

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11534013: Issue 7282. Report error for deprecated === and !== (Closed)

Created:
8 years ago by scheglov

Modified:
8 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 7282. Report error for deprecated === and !== http://code.google.com/p/dart/issues/detail?id=7282 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15989

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -29 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java	View	3 chunks	+21 lines, -26 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+42 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/utils/utils.status	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years ago (2012-12-11 17:28:14 UTC) #2

LGTM

https://codereview.chromium.org/11534013/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java (right):

https://codereview.chromium.org/11534013/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:44:
DEPRECATED_STRICT_NE("Deprecated use of '!==', use 'identical()' or '!='
instead."),
Would it be confusing to write "!identical()"? Perhaps we should leave it as is.

https://codereview.chromium.org/11534013/diff/1/compiler/javatests/com/google...
File
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
(right):

https://codereview.chromium.org/11534013/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:243:
"var b = null;"));
Given that this is no longer testing an expression involving null, I think we
should just remove the test.

Expand Messages | Collapse Messages