Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1153363003: dart2js: Avoid common prefix for frequent bad names. (Closed)

Created:
5 years, 7 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
karlklose, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
herhut
This helps a little with programs that have a lot of top-level closures.
5 years, 7 months ago (2015-05-28 09:18:48 UTC) #1
herhut
ping?
5 years, 6 months ago (2015-06-09 09:13:40 UTC) #3
karlklose
LGTM.
5 years, 6 months ago (2015-06-09 09:16:40 UTC) #4
karlklose
LGTM.
5 years, 6 months ago (2015-06-09 09:16:41 UTC) #5
sra1
lgtm
5 years, 6 months ago (2015-06-09 19:50:59 UTC) #6
herhut
5 years, 6 months ago (2015-06-10 09:31:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5db566371ebc52ac264923d232c8dbc77938ab3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698