Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 11533006: Added supressions of test failures on Safari for {corelib,language,html} (Closed)

Created:
8 years ago by kustermann
Modified:
8 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added supressions of test failures on Safari for {corelib,language,html} Committed: https://code.google.com/p/dart/source/detail?r=15987

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tests/corelib/corelib.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/html.status View 1 2 chunks +6 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
After this change, we can hopefully move "dart2js-safari-mac" to the main waterfall.
8 years ago (2012-12-11 14:53:53 UTC) #1
ahe
Sorta LGTM https://codereview.chromium.org/11533006/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/11533006/diff/1/tests/corelib/corelib.status#newcode6 tests/corelib/corelib.status:6: [ $runtime == safari ] How about ...
8 years ago (2012-12-11 15:00:22 UTC) #2
kustermann
PTAL https://codereview.chromium.org/11533006/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/11533006/diff/1/tests/corelib/corelib.status#newcode6 tests/corelib/corelib.status:6: [ $runtime == safari ] On 2012/12/11 15:00:22, ...
8 years ago (2012-12-11 15:55:34 UTC) #3
ahe
8 years ago (2012-12-11 17:17:54 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698