Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153033007: Add python based VERSION file generation for sdk bots (Closed)

Created:
5 years, 7 months ago by ricow1
Modified:
5 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add python based VERSION file generation for sdk bots We used to have this file generated by the editor build BUG=23516 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/af3b6b2b617fd543f1d16f6d967d06feb702f58d

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M tools/bots/dart_sdk.py View 2 chunks +16 lines, -0 lines 0 comments Download
M tools/utils.py View 1 4 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ricow1
5 years, 7 months ago (2015-05-28 08:49:12 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1153033007/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/1153033007/diff/1/tools/utils.py#newcode324 tools/utils.py:324: # The editor used to procude the VERSION ...
5 years, 7 months ago (2015-05-28 09:18:52 UTC) #3
ricow1
https://codereview.chromium.org/1153033007/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/1153033007/diff/1/tools/utils.py#newcode324 tools/utils.py:324: # The editor used to procude the VERSION file. ...
5 years, 7 months ago (2015-05-28 09:20:06 UTC) #4
ricow1
5 years, 7 months ago (2015-05-28 09:20:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
af3b6b2b617fd543f1d16f6d967d06feb702f58d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698