Issue 11530008: Fix newly added regression test that left processes hanging on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11530008: Fix newly added regression test that left processes hanging on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix newly added regression test that left processes hanging on Windows. The issue is that the main process died too soon when the test passes. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15958

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	tests/standalone/io/regress_7191_script.dart	View		1 chunk	+3 lines, -3 lines	1 comment	Download
	M	tests/standalone/io/regress_7191_test.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years ago (2012-12-11 09:57:44 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/11530008/diff/1/tests/standalone/io/regress_7...
File tests/standalone/io/regress_7191_script.dart (right):

https://codereview.chromium.org/11530008/diff/1/tests/standalone/io/regress_7...
tests/standalone/io/regress_7191_script.dart:13: var data = stdin.read();
Check that data is [0] here as well?

Expand Messages | Collapse Messages