Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1152963003: Split resolution/members.dart into several parts. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split resolution/members.dart into several parts. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/a50be4b0c1d2ff2af162130df4842e0bcdae6294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2475 lines, -52155 lines) Patch
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 3 chunks +1 line, -4889 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +232 lines, -5280 lines 0 comments Download
M pkg/compiler/lib/src/resolution/label_scope.dart View 1 chunk +65 lines, -5490 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +1915 lines, -5101 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 4 chunks +22 lines, -4499 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +1 line, -5480 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 3 chunks +1 line, -5060 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +227 lines, -5490 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 2 chunks +1 line, -5404 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 2 chunks +1 line, -5462 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-26 09:42:03 UTC) #2
karlklose
LGTM.
5 years, 7 months ago (2015-05-26 09:44:58 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-26 09:45:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a50be4b0c1d2ff2af162130df4842e0bcdae6294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698