Fix extraction of environment variables on Windows.

Fix extraction of environment variables on Windows.

Environment variables were extracted using GetEnvironmentStringsA
and that does not play nice with for instance Danish letters
in environment variables.

This causes problems for pub if the current user has an
internationalized name.

This is the first patch in a series that will switch to the
unicode APIs on Windows.

R=sgjesse@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15977

[Mads Ager (google), 2012-12-11 14:32:59]

+rnystrom

[Søren Gjesse, 2012-12-11 14:39:47]

lgtm

https://codereview.chromium.org/11529008/diff/1/runtime/bin/platform_win.cc
File runtime/bin/platform_win.cc (right):

https://codereview.chromium.org/11529008/diff/1/runtime/bin/platform_win.cc#n...
runtime/bin/platform_win.cc:40: char* utf8 =
reinterpret_cast<char*>(malloc(len+1));
Spaces in arithmetic expression.

https://codereview.chromium.org/11529008/diff/1/tests/standalone/io/windows_e...
File tests/standalone/io/windows_environment_script.dart (right):

https://codereview.chromium.org/11529008/diff/1/tests/standalone/io/windows_e...
tests/standalone/io/windows_environment_script.dart:9:
//Expect.isTrue(scriptDir.contains('å'));
Code in comment.

[Mads Ager (google), 2012-12-11 14:41:54]

https://codereview.chromium.org/11529008/diff/1/runtime/bin/platform_win.cc
File runtime/bin/platform_win.cc (right):

https://codereview.chromium.org/11529008/diff/1/runtime/bin/platform_win.cc#n...
runtime/bin/platform_win.cc:40: char* utf8 =
reinterpret_cast<char*>(malloc(len+1));
On 2012/12/11 14:39:47, Søren Gjesse wrote:
> Spaces in arithmetic expression.

Done.

https://codereview.chromium.org/11529008/diff/1/tests/standalone/io/windows_e...
File tests/standalone/io/windows_environment_script.dart (right):

https://codereview.chromium.org/11529008/diff/1/tests/standalone/io/windows_e...
tests/standalone/io/windows_environment_script.dart:9:
//Expect.isTrue(scriptDir.contains('å'));
On 2012/12/11 14:39:47, Søren Gjesse wrote:
> Code in comment.

Whoops. Added the code again.