Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11529007: Add Lasse's test case from dartbug.com/6451. (Closed)

Created:
8 years ago by ngeoffray
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Lasse's test case from dartbug.com/6451. Committed: https://code.google.com/p/dart/source/detail?r=15964

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
A tests/language/invocation_mirror2_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years ago (2012-12-11 10:28:31 UTC) #1
kasperl
https://codereview.chromium.org/11529007/diff/1/tests/language/invocation_mirror2_test.dart File tests/language/invocation_mirror2_test.dart (right): https://codereview.chromium.org/11529007/diff/1/tests/language/invocation_mirror2_test.dart#newcode15 tests/language/invocation_mirror2_test.dart:15: Expect.equals(42, c.im.positionalArguments[0]); Double space before c. https://codereview.chromium.org/11529007/diff/1/tests/language/language.status File tests/language/language.status ...
8 years ago (2012-12-11 10:48:50 UTC) #2
ngeoffray
Thanks Kasper, PTAL https://codereview.chromium.org/11529007/diff/1/tests/language/invocation_mirror2_test.dart File tests/language/invocation_mirror2_test.dart (right): https://codereview.chromium.org/11529007/diff/1/tests/language/invocation_mirror2_test.dart#newcode15 tests/language/invocation_mirror2_test.dart:15: Expect.equals(42, c.im.positionalArguments[0]); On 2012/12/11 10:48:50, kasperl ...
8 years ago (2012-12-11 10:59:45 UTC) #3
kasperl
8 years ago (2012-12-11 11:29:17 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698