Add a runtime flag to control availability of dart:mirrors.

Add a runtime flag to control availability of dart:mirrors.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/d42ff1052f990f03ab9b4a94ca25ce85a15f2fa4

[rmacnak, 2015-05-22 18:41:09]

rmacnak@google.com changed reviewers:
+ asiva@google.com, iposva@google.com

[Ivan Posva, 2015-05-29 06:02:25]

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart.cc#newcode284
runtime/vm/dart.cc:284:
Object::Handle(isolate->object_store()->mirrors_library());
Should we at this point set the value in the object store for the mirrors
library to null as well?

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart.cc#newcode288
runtime/vm/dart.cc:288: const GrowableObjectArray& old_libs =
Instead of creating a new array, you could find the index of the mirrors
library, overwrite it with the last entry and shrink they array.

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5469: if (!libmirrors.IsNull()) {
Here we are not relying on the flag being set, but on the fact that the mirrors
library is null instead of the flag value, which makes me think that we should
reset it as necessary.

[rmacnak, 2015-06-13 00:11:10]

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1152833002/diff/1/runtime/vm/dart.cc#newcode284
runtime/vm/dart.cc:284:
Object::Handle(isolate->object_store()->mirrors_library());
On 2015/05/29 06:02:24, Ivan Posva wrote:
> Should we at this point set the value in the object store for the mirrors
> library to null as well?

Actually, this is unsafe. We sometimes lookup libraries by id.

Updated to just be a check on imports. We'll really remove the library at build
time for precompilation.

[siva, 2015-06-16 15:46:18]

lgtm

[rmacnak, 2015-06-16 17:01:49]

Committed patchset #3 (id:40001) manually as
d42ff1052f990f03ab9b4a94ca25ce85a15f2fa4 (presubmit successful).