Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 11528007: Use old import syntax. (Closed)

Created:
8 years ago by Anton Muhin
Modified:
8 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use old import syntax. As of now, new import syntax doesn't play well with DRT wrapping. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/utils/dart2js_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
8 years ago (2012-12-11 13:51:01 UTC) #1
ahe
Please revert this.
8 years ago (2012-12-11 13:53:06 UTC) #2
ahe
8 years ago (2012-12-11 14:02:38 UTC) #3
Message was sent while issue was closed.
More info:

* This is another instance of http://dartbug.com/2264.

* We are trying to move away from old syntax.

* This test is pointless on Dartium.

* This makes the test fail on dartc, but passing on dartc was the sole purpose
of this test.

A better solution is to either skip a test, or mark it as "fail".

Powered by Google App Engine
This is Rietveld 408576698