Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1152773002: Manage 'libraries containing part' in DartWorkManager. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Manage 'libraries containing part' in DartWorkManager. It is on the couple critical paths: 1. getErrors() 2. SearchEngine. The SearchEngine is used in both search itself and by completion. Without this change search has n^2 complexity, where `n` is the number of targets. Statistics for search shows more than 10x performance improvement. Before: 70 ms (analyzer), 230 ms (analyzer + dart2js). After: 6 ms (analyzer), 17 ms (analyzer + dart2js). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/224734d4e41400d256ac0106302674351aa37bd9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -13 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -13 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 5 chunks +77 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 3 chunks +120 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-22 15:57:23 UTC) #1
Brian Wilkerson
LGTM It's not surprising that we need this. We needed it in the old system ...
5 years, 7 months ago (2015-05-22 16:05:42 UTC) #2
scheglov
5 years, 7 months ago (2015-05-22 16:21:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
224734d4e41400d256ac0106302674351aa37bd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698