Service cleanups...

Service cleanups...

- Allow for multiple breakpoints in the service protocol.
  The info isn't actually provided or used yet.
- Drop index for list elements returned by the protocol.  Flatten structure.
- Drop index for context elements.  Keep sub-structure so we
   can choose to add extra slot info later.
- Errors now have ids and kinds.
- exception and stacktrace move from @Error to Error.
- All heap Objects now include class/size.
- Changed BoundedType.type and TypeRef.type to different names.
  Turns out we already have a "type" property that conflicts.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/1b59b9ea0603c868ddf89e0626c6b94996f6fa42

[turnidge, 2015-06-04 05:16:35]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[turnidge, 2015-06-04 05:16:36]

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:1604: const Class& cls = Class::Handle(this->clazz());
If I add the "class" property to every ref, then we end up with the full class
superclass chained spewed out in every ref.  If we want to move the class into
the ref later, it will be backwards compatible, so I would rather leave it as a
full-object-only field for now (except for instances).

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13040: JSONObject jselement(&jsarr);
Leaving this structure here so that we could add extra context info later.

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:15523: jsobj.AddProperty("referentType",
AbstractType::Handle(type()));
There is already a "type" property.

[Cutch, 2015-06-04 13:16:15]

lgtm

https://codereview.chromium.org/1152753005/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/context_ref.html (right):

https://codereview.chromium.org/1152753005/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/context_ref.html:19: <template repeat="{{
index in ref.variables.asMap().keys }}">
Can we add a TODO to remove the call to 'asMap'?

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:1604: const Class& cls = Class::Handle(this->clazz());
On 2015/06/04 05:16:36, turnidge wrote:
> If I add the "class" property to every ref, then we end up with the full class
> superclass chained spewed out in every ref.  If we want to move the class into
> the ref later, it will be backwards compatible, so I would rather leave it as
a
> full-object-only field for now (except for instances).

Acknowledged.

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13040: JSONObject jselement(&jsarr);
On 2015/06/04 05:16:36, turnidge wrote:
> Leaving this structure here so that we could add extra context info later.

Acknowledged.

https://codereview.chromium.org/1152753005/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:15523: jsobj.AddProperty("referentType",
AbstractType::Handle(type()));
On 2015/06/04 05:16:35, turnidge wrote:
> There is already a "type" property.

Acknowledged.

[turnidge, 2015-06-04 15:54:43]

https://codereview.chromium.org/1152753005/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/context_ref.html (right):

https://codereview.chromium.org/1152753005/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/context_ref.html:19: <template repeat="{{
index in ref.variables.asMap().keys }}">
On 2015/06/04 13:16:15, Cutch wrote:
> Can we add a TODO to remove the call to 'asMap'?

See the discussion here...

http://stackoverflow.com/questions/19431835/get-index-in-dart-polymer-repeat-...

This seems like a "standard" solution to the template repeat enumeration
problem, so I think we just keep it.

[turnidge, 2015-06-04 16:09:28]

Committed patchset #2 (id:20001) manually as
1b59b9ea0603c868ddf89e0626c6b94996f6fa42 (presubmit successful).