Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1152413002: pkg/pool: Revert "Revert r38549, r38552, and r38557." (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/pool.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert r38549, r38552, and r38557." This reverts commit 9bf6a8ec011fb52fa259109760f649567d514813. R=nweiz@google.com Committed: https://github.com/dart-lang/pool/commit/64b50e37cb2d966e98cf82e29ef2be20f61fbc51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -73 lines) Patch
A CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/pool.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M test/pool_test.dart View 4 chunks +120 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 7 months ago (2015-05-23 01:32:08 UTC) #2
nweiz
lgtm
5 years, 7 months ago (2015-05-23 01:32:58 UTC) #3
kevmoo
5 years, 7 months ago (2015-05-23 01:33:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64b50e37cb2d966e98cf82e29ef2be20f61fbc51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698