Issue 1152333005: fix windows bots with Platform.executable test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152333005: fix windows bots with Platform.executable test (Closed)

Created:
5 years, 7 months ago by kevmoo

Modified:
5 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix windows bots with Platform.executable test TBR Committed: https://github.com/dart-lang/sdk/commit/d5e8d7723d21c501edfb6d38254e0230027d02f1

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	tests/standalone/io/platform_executable_test.dart	View		4 chunks	+10 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

Committed patchset #2 (id:20001) manually as d5e8d7723d21c501edfb6d38254e0230027d02f1 (presubmit successful).

5 years, 7 months ago (2015-05-25 18:26:49 UTC) #1

Søren Gjesse

5 years, 7 months ago (2015-05-26 07:27:55 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1152333005/diff/20001/tests/standalone/io/pla...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1152333005/diff/20001/tests/standalone/io/pla...
tests/standalone/io/platform_executable_test.dart:49:
Process.runSync(platformExeName, [platformExeName],
Why are you passing [platformExeName] here?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages