Issue 11523002: Pass the proper invocation mirror argument to noSuchMethod.

Issue 11523002: Pass the proper invocation mirror argument to noSuchMethod. (Closed)

Created:
8 years ago by regis

Modified:
8 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Pass the proper invocation mirror argument to noSuchMethod. Committed: https://code.google.com/p/dart/source/detail?r=15939

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -86 lines)			Patch
M	runtime/lib/error.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/lib/error.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View	1 2	1 chunk	+39 lines, -4 lines	0 comments	Download
M	runtime/lib/object.cc	View	1 2	1 chunk	+28 lines, -26 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View	1 2	1 chunk	+9 lines, -5 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2	7 chunks	+10 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	6 chunks	+6 lines, -16 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	6 chunks	+6 lines, -16 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11523002/diff/1/runtime/lib/invocation_mirror_patch.dart File runtime/lib/invocation_mirror_patch.dart (right): https://codereview.chromium.org/11523002/diff/1/runtime/lib/invocation_mirror_patch.dart#newcode12 runtime/lib/invocation_mirror_patch.dart:12: // arguments descriptor. Maybe change comment, something like: ...

8 years ago (2012-12-10 23:55:39 UTC) #2

regis

8 years ago (2012-12-11 00:11:04 UTC) #3

Thanks!

https://codereview.chromium.org/11523002/diff/1/runtime/lib/invocation_mirror...
File runtime/lib/invocation_mirror_patch.dart (right):

https://codereview.chromium.org/11523002/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:12: // arguments descriptor.
On 2012/12/10 23:55:39, srdjan wrote:
> Maybe change comment, something like:
> 
> Compute lazily the value of these fields, and save the arguments passed into
> _allocateInvocationMirror.

Done.

https://codereview.chromium.org/11523002/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:25: static
_allocateInvocationMirror(name, argumentsDescriptor, arguments) {
On 2012/12/10 23:55:39, srdjan wrote:
> Add types (result and arguments).

The types were omitted on purpose, since this is an internal call. Done.

https://codereview.chromium.org/11523002/diff/1/runtime/lib/object_patch.dart
File runtime/lib/object_patch.dart (right):

https://codereview.chromium.org/11523002/diff/1/runtime/lib/object_patch.dart...
runtime/lib/object_patch.dart:30: native "Object_noSuchMethod";
On 2012/12/10 23:55:39, srdjan wrote:
> remove 'dynamic' as result type. Add space after comma 'Map<String, dynanic>'

Done.

Expand Messages | Collapse Messages