Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 11522006: Get pub_lish tests running on Windows. (Closed)

Created:
8 years ago by Bob Nystrom
Modified:
8 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get pub_lish tests running on Windows. There were two issues: 1. We were printing 7zip's stderr to pub's stderr which confuses the tests that look for certain errors. 2. Sometimes deleting the sandbox fails because the spawned pub process hasn't shut down yet. To handle that, we just retry the delete a few times. <sigh> Committed: https://code.google.com/p/dart/source/detail?r=15935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -40 lines) Patch
M utils/pub/io.dart View 4 chunks +38 lines, -25 lines 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +12 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bob Nystrom
8 years ago (2012-12-10 23:04:02 UTC) #1
nweiz
8 years ago (2012-12-10 23:05:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698