Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1152013006: Test all methods in semantic_visitor_test. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -24 lines) Patch
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 5 chunks +53 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 9 chunks +147 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 4 chunks +149 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-04 11:10:23 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-04 11:49:23 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-07 08:31:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
deb1697fa96d2a5a2c7e718ec4d9ab0107da39bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698