Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1151753006: Upgrade tests to the new version of test package (Closed)

Created:
5 years, 6 months ago by Alexander Ivanov
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upgrade tests to the new version of test package Upgrade to test 0.12.2, because unittest(test < 0.12) package is already obsolete. BUG= R=lrn@google.com, sgjesse@google.com Committed: https://github.com/dart-lang/crypto/commit/f476702eba6439819bee32e6c37171a15d7bd185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/base64_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/hmac_md5_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/hmac_sha1_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/hmac_sha256_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/sha1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/sha256_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Alexander Ivanov
5 years, 6 months ago (2015-05-28 10:25:11 UTC) #2
Søren Gjesse
lgtm
5 years, 6 months ago (2015-05-28 10:34:51 UTC) #3
Lasse Reichstein Nielsen
lgtm
5 years, 6 months ago (2015-05-28 11:26:30 UTC) #4
Alexander Ivanov
5 years, 6 months ago (2015-05-28 13:06:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f476702eba6439819bee32e6c37171a15d7bd185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698